Code review comment for lp:~vanvugt/mir/surface-types

8 +Package: mircommon-dev

I don't think this is right as it stands - but that is probably part of a pre-existing problem with the install packages and directory structure.

We need to be able to install the client process toolkit headers. (shared/mir_toolkit/* + client/mir_toolkit/*)

We need to be able to install the server process toolkit headers. (shared/mir_toolkit/* + server/mir_toolkit/*)

We need to be able to install for building against the library headers. (shared/mir/* + server/mir/* + shared/mir_toolkit/common.h)

I don't have a better proposal to hand, but something needs fixing.

~~~~

As I've said before I don't think that surfaces::Surface needs configure(MirSurfaceAttrib attrib, int value) - AFICS attributes are a feature of shell::Surface.

But I guess we can delete it a few minutes after it lands.