Mir

Code review comment for lp:~vanvugt/mir/super-simple-connect

Revision history for this message
Chris Halse Rogers (raof) wrote :

Another +1 for *_sync vs s*.

I'm not averse to having a separate, synchronous, header, but I think that as long as we maintain the convention of having _sync stuck on the end of anything that can block it's not particularly necessary.

If you call mir_connect_sync, it's pretty clear you don't want asynchronous behaviour, so I don't think we need to segregate the sync calls out for client's safety.

review: Approve

« Back to merge proposal