Mir

Code review comment for lp:~vanvugt/mir/super-simple-connect

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

It's true that making up new words like "sconnect" is one way to avoid ambiguity. But it steepens the learning curve. Another possible convention is "mir_connect_now", which is a clear message to the reader that "mir_connect" might not connect /right now/.

Separate headers? I disagree. This function relates directly to the existing contents of mir_client_library.h. Separate headers would also steepen the learning curve and it would be generally bad design to have a "connect" function in a different header to its requisite disconnect function.

« Back to merge proposal