Mir

Code review comment for lp:~vanvugt/mir/single-buffer

Revision history for this message
Chris Halse Rogers (raof) wrote :

You don't seem to be responding to any of the concerns raised here?

Specifically:
*) it seems that this will require code outside the BufferBundle implementation to support cases that aren't necessary in multi-buffering.
*) unless you ensure exclusivity we are at best invoking undefined rendering and at worst undefined behaviour in libGL
 +) Relatedly, Android has no GL-accessible frontbuffer; if we do this we're attempting to use behaviour unsupported by the drivers' major target.
*) if you ensure exclusivity, how does that interact with the compositor loop and client API?

In return for all these problems and potential problems, we gain a feature with at best a niche use-case.

« Back to merge proposal