Mir

Code review comment for lp:~vanvugt/mir/simplify-DisplayReport

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Andreas,
Me too. And I was arguing for that kind of simple logging before we had "reports". It has many benefits that you touched on. However if you design a "report" interface carefully then it's potentially very useful in instrumenting to data sinks that aren't necessarily logging (LTTng et al). Still, I feel the right answer is to have both. Because "reports" as they are today in Mir are too brittle (their design is uncomfortably coupled to the logic of another module) and slow to evolve (multiple classes plus tests) compared to adding new log messages.

Back on the subject of this proposal, I'm happy to reject it if we get a third disapproving review :)

« Back to merge proposal