Mir

Code review comment for lp:~vanvugt/mir/simplify-BufferQueue

Revision history for this message
Chris Halse Rogers (raof) wrote :

Wasn't the use of std::vector for current_buffer_users driven by profiling? What is the cost of an unordered_set for this?

The simplification of client_acquire looks good to me.

It seems like the behavioural change here is not checking for !resize_buffer - what is the consequence of that? Is the fact that you can make this change without breaking tests a bug in the existing code, or a bug in the tests?

review: Needs Information

« Back to merge proposal