Mir

Code review comment for lp:~vanvugt/mir/save-resources-in-the-renderer

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

111 + display_buffer.post_update();
112 renderer->end();
113
114 - display_buffer.post_update();

I am torn. My main issue is that the usual order is to have distinct phases: render, post, render, post etc, so the need to reorder post and renderer->end() is not intuitive. If I was given the interfaces without any knowledge of the internals I would use them like we did before (first end then post).

I understand the motivation, but this now makes the interface tricky to use. We should at least clearly document in the Renderer interface how operations should be ordered, but ideally we should find a way to make correct use more intuitive at the interface level.

review: Abstain

« Back to merge proposal