Mir

Code review comment for lp:~vanvugt/mir/saucy-build

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

> The point: *if* we want some preconditions to be conditions in debug builds,
> then it makes sense for the corresponding tests to be conditionally compiled.
>
> Personally, I don't think these checks should ever be conditions *with tests
> to validate the behavior*. But unless there are performance reasons I feel
> that is is as important to aid problem diagnosis in release builds as in debug
> ones.

OK, I am convinced. My preference would be to remove the test, but I can live with it for now.

review: Approve

« Back to merge proposal