Mir

Code review comment for lp:~vanvugt/mir/saucy-build

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

58 +#ifdef NDEBUG

Instead of disabling the test I would propose replacing the assert() in the MirTestFramework contstructor with "if (...) abort()" as a temporary measure (like in Stephen's branch).

However, replacing all assert()s with our own variant which doesn't care about NDEBUG (the "Right Way"), doesn't seem to require too much effort, so why not go for it?

review: Needs Fixing

« Back to merge proposal