Having seen an entropy related failure in an unrelated job (lp:1558518) on the same box I'm concerned about the tests this activates. Specifically:
// Flush the entropy pool
int fd = open("/dev/random", O_RDONLY | O_NONBLOCK);
ASSERT_THAT(fd, Ge(0));
char buf[256];
while (read(fd, buf, sizeof buf) > 0) {}
close(fd);
Affects the whole machine not just the current test. While it could be argued that this also lands the fix and other builds then be unaffected we can't assume that will always be true.
*Needs Discussion*
Having seen an entropy related failure in an unrelated job (lp:1558518) on the same box I'm concerned about the tests this activates. Specifically:
// Flush the entropy pool
int fd = open("/dev/random", O_RDONLY | O_NONBLOCK);
ASSERT_THAT(fd, Ge(0));
char buf[256];
while (read(fd, buf, sizeof buf) > 0) {}
close(fd);
Affects the whole machine not just the current test. While it could be argued that this also lands the fix and other builds then be unaffected we can't assume that will always be true.
I'd rather drop these tests.