Mir

Code review comment for lp:~vanvugt/mir/reverse-scene-traversal

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

43 + for ( auto layer = layers_by_depth.rbegin()
44 + ; layer != layers_by_depth.rend()
45 + ; ++layer
46 + )

Although I don't find anything in our coding standard about this, we tend to break lines after punctuation marks.

Use std::for_each() instead?

49 + for (auto it = surfaces.rbegin(); it != surfaces.rend(); ++it)
50 + {

Use std::for_each() instead?

review: Needs Fixing

« Back to merge proposal