Mir

Code review comment for lp:~vanvugt/mir/remove-callbacks-mir_connect

  1. remove-callbacks-mir_connect
  2. Merge into trunk
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

The API is still asynchronous. I'm not sure the stakeholders even conceived that it could be so without callbacks. And if callbacks are still required, they should be attached to a MirWaitHandle in the spirit of:
  mir_callback_on_completion(waithandle, callback, data);

I hope we can resolve this. The API is presently so awful that I refuse to use it. And I won't be the only one.

« Back to merge proposal