Mir

Code review comment for lp:~vanvugt/mir/privatize-input

Revision history for this message
Robert Carr (robertcarr) wrote :

I share some concern with this approach. Notably I think currently we have this hierarchy:

Public headers
Component public
Component private

We currently express public headers and component public in the same way (set in include/).

This approach collapses the notion of component public/private and I think we lose some ability to express organization with this approach.

On the other hand, I think these headers will have to move again as part of the big ABI rework, and not installing them for now certainly seems an improvement.

review: Approve

« Back to merge proposal