Mir

Merge lp:~vanvugt/mir/privatize-SurfaceData into lp:mir

Proposed by Daniel van Vugt
Status: Merged
Approved by: Alan Griffiths
Approved revision: no longer in the source branch.
Merged at revision: 1098
Proposed branch: lp:~vanvugt/mir/privatize-SurfaceData
Merge into: lp:mir
Diff against target: 38 lines (+3/-3)
3 files modified
src/server/surfaces/surface_allocator.cpp (+1/-1)
src/server/surfaces/surface_data.cpp (+1/-1)
tests/unit-tests/surfaces/test_surface_data.cpp (+1/-1)
To merge this branch: bzr merge lp:~vanvugt/mir/privatize-SurfaceData
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Alan Griffiths Approve
Review via email: mp+188787@code.launchpad.net

Commit message

Privatize surface_data.h; not required in any public APIs.

Description of the change

A small step on the long road to server API stability (LP: #1223393).

To post a comment you must log in.
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

LGTM (moving a file from include/server is, of course, an API break.)

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/server/surfaces/surface_allocator.cpp'
--- src/server/surfaces/surface_allocator.cpp 2013-08-28 03:41:48 +0000
+++ src/server/surfaces/surface_allocator.cpp 2013-10-02 09:43:03 +0000
@@ -20,7 +20,7 @@
20#include "mir/surfaces/buffer_stream_factory.h"20#include "mir/surfaces/buffer_stream_factory.h"
21#include "mir/surfaces/buffer_stream.h"21#include "mir/surfaces/buffer_stream.h"
22#include "mir/input/input_channel_factory.h"22#include "mir/input/input_channel_factory.h"
23#include "mir/surfaces/surface_data.h"23#include "surface_data.h"
24#include "mir/surfaces/surface.h"24#include "mir/surfaces/surface.h"
2525
26namespace geom=mir::geometry;26namespace geom=mir::geometry;
2727
=== modified file 'src/server/surfaces/surface_data.cpp'
--- src/server/surfaces/surface_data.cpp 2013-08-28 03:41:48 +0000
+++ src/server/surfaces/surface_data.cpp 2013-10-02 09:43:03 +0000
@@ -16,7 +16,7 @@
16 * Authored by: Kevin DuBois <kevin.dubois@canonical.com>16 * Authored by: Kevin DuBois <kevin.dubois@canonical.com>
17 */17 */
1818
19#include "mir/surfaces/surface_data.h"19#include "surface_data.h"
20#include <glm/gtc/matrix_transform.hpp>20#include <glm/gtc/matrix_transform.hpp>
2121
22namespace geom=mir::geometry;22namespace geom=mir::geometry;
2323
=== renamed file 'include/server/mir/surfaces/surface_data.h' => 'src/server/surfaces/surface_data.h'
=== modified file 'tests/unit-tests/surfaces/test_surface_data.cpp'
--- tests/unit-tests/surfaces/test_surface_data.cpp 2013-08-28 03:41:48 +0000
+++ tests/unit-tests/surfaces/test_surface_data.cpp 2013-10-02 09:43:03 +0000
@@ -16,7 +16,7 @@
16 * Authored by: Kevin DuBois <kevin.dubois@canonical.com>16 * Authored by: Kevin DuBois <kevin.dubois@canonical.com>
17 */17 */
1818
19#include "mir/surfaces/surface_data.h"19#include "src/server/surfaces/surface_data.h"
2020
21#include "mir/geometry/rectangle.h"21#include "mir/geometry/rectangle.h"
2222

Subscribers

People subscribed via source and target branches