Mir

Code review comment for lp:~vanvugt/mir/predictive-bypass-v3

Revision history for this message
Kevin DuBois (kdub) wrote :

my complaints from v1 and v2 look addressed, lgtm!
Further improvements might be:
1) We can detect the device name on the android platform (via mga::DeviceQuirks), so we could have device-specific times.
2) This is passive (the MTC asks the DisplayGroup how long to wait), but I wouldn't mind the display hardware telling the MTC its ready to composite. (and mtc gets final say whether it does composite or not). This would also make the test for MTC less timing dependendent.

review: Approve

« Back to merge proposal