Mir

Code review comment for lp:~vanvugt/mir/posix-timestamp-or-equal

  1. posix-timestamp-or-equal
  2. Merge into development-branch
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Indeed the name starts with a virtual conjunction, and virtual quotes too :)

   "or-equal" comparison operators

I can see how that creates a mildly confusing test name, but I don't see why other other test name "PosixTimestamp.comparison" is confusing. At least not confusing if I merge the two tests. The thought had crossed my mind, but I didn't think it was as important as proposing a cleaner diff that a new test case provides.

« Back to merge proposal