Mir

Code review comment for lp:~vanvugt/mir/posix-timestamp-or-equal

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

The proposed test name starts with a conjunction. I've no objection to this in writing where there is a clear reference to the preceding sentence, but as a test name?

How do the other test names justify this?

Of the comparison operators operator==() is tested in "PosixTimestamp.equal".

There is no test (or implementation of) operator!=().

Two of the relational operators are tested in "PosixTimestamp.comparison" - that's not a great name either, but it does give some idea of what the test covers.

This tests covers the remaining relational operators. (They could be more simply implemented as negations of the last two mentioned above, but that doesn't really gain anything.)

« Back to merge proposal