Mir

Code review comment for lp:~vanvugt/mir/parenting-server-api

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

59 + virtual void set_parent(std::weak_ptr<Surface> const&, int id) = 0;

It can't be right that both a pointer and an int are passed here.

Presumably they are both ways of referencing the same parent and passing them separately makes the interface easy to abuse.

review: Needs Fixing

« Back to merge proposal