Mir

Code review comment for lp:~vanvugt/mir/overlay-terminology-is-awkward

Revision history for this message
Kevin DuBois (kdub) wrote :

The naming is a bit out-of-date. Breaking ABI for this wouldn't be worth it, but as it is, we've already broken abi here, so we may as well rename.

This also could do with an update to use the recently-added native_display_buffer() mechanism, but that can be for later.

suggestion:
try_to_composite is better than the current name, but we might not be compositing at all. Maybe just set_overlays() ?

needs fixing:
This bit of documentation needs updating as well:
     * When this call completes, the renderlist will have been posted
     * to the screen.

review: Needs Fixing

« Back to merge proposal