Code review comment for lp:~vanvugt/mir/output-model
Revision history for this message
| Chris Halse Rogers (raof) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
+1 on mir::graphics being the sensible spot for it.
213 + enum { minimum_size = 128 };
This would be more idiomatic as static constexpr, but that's non-blocking.
Either here, or in future work, it would make sense to validate the checksum on the EDID. This could be done in a static “constructor” in Edid::. Which would also be nice, rather than have the expectation that you reinterpret_cast<> a bunch of bytes into a mg::Edid.