Mir

Code review comment for lp:~vanvugt/mir/output-model

  1. output-model
  2. Merge into development-branch
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

+struct EDID

1. I don't see any advantage to having the implementation inline. Can we put it in a .cpp file?

2. Having an UPPERCASE name is potentially confusing - we use that for MACROS.

review: Needs Fixing

« Back to merge proposal