Code review comment for lp:~vanvugt/mir/modifier-groups

OK with this as long as there is no good reason for having separate alt/shift/ctrl values in the first place. I vaguely remember some discussions about this, but not the conclusion. Robert?

Also, since this is a breaking change anyway, why not reorganize the enum to avoid holes?

> This stuff appeared in r2129 so first released in Mir 0.10.0. I think that makes it
> new enough that we can safely change the API without anyone complaining.

That's only true as long as no one uses 0.10 and then moves to a later version. I don't think we have the luxury to skip bumps in the client ABI as we have been doing on some occasions on the server side.