Mir

Code review comment for lp:~vanvugt/mir/mir-display-config-header

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

The intended API you imply (which is only hearsay right now and less related to the real API that exists) is both too wordy and also involves breaking the ABI. So I still maintain this proposal is the best way forward since it does not have those problems.

As for "created" vs "get", "created" is a historical mistake. We are not creating the display config; we are only copying it from the server. Hence "get" or "copy" is a more appropriate verb than "create".

I think a reasonable person reading these comments will agree with me so am waiting on more votes.

« Back to merge proposal