Mir

Code review comment for lp:~vanvugt/mir/mir-display-config-header

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> There is a clean path forward. I thought it was obvious but let me explain:
>
> 1. Land this branch to make the file name consistent with the "new" API.

You've already collected two "Disapproves" because this MP is not consistent the intended API - it moves the "wrong way".

It is obviously possible to get to places other than the intended API with only one ABI break, but that's not what I've been questioning.

> 2. Add a new function (so it's not an API break) that wraps the remaining
> inconsistent function Alan mentioned, but using the correct naming convention:
>
> MirDisplayConfig* mir_connection_get_display_config(MirConnection* connection)
> {
> return mir_connection_create_display_configuration(connection);
> }

Doesn't that break the convention that things that are "created" need to be released while "get" is for things that don't?

« Back to merge proposal