Mir

Code review comment for lp:~vanvugt/mir/mir-display-config-header

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> In the 1.0 API cleanup discussion we decided to go with
> MirDisplayConfiguration and mir_display_configuration_* naming. This MP
> proposes the opposite of what we decided.

Color me confused: mir_toolkit/mir_connection.h has this...

    /**
     * Query the display
     *
     * \deprecated Use mir_connection_create_display_configuration() instead.
     *
     * \warning return value must be destroyed via mir_display_config_destroy()
     * \warning may return null if connection is invalid
     * \param [in] connection The connection
     * \return structure that describes the display configuration
     */
    MirDisplayConfiguration* mir_connection_create_display_config(MirConnection *connection);

And mir_connection_create_display_configuration() returns MirDisplayConfig, so we're already in the process of deprecating use of MirDisplayConfiguration in favour of MirDisplayConfig and have decided to reverse that but use the new function names?

I don't see the intermediate steps that get us there.

review: Needs Information

« Back to merge proposal