Mir

Code review comment for lp:~vanvugt/mir/managed-surface

Revision history for this message
Alberto Aguirre (albaguirre) wrote :

Surface wrapper looks like a convenient class to have for mir server clients (though a client could of course roll their own as it's a straightforward wrapper), though that implies the client is willing to use dynamic_cast for downcasting, instead of using other means like associative containers.

As for managed surface, I would prefer a cleaner delineation between model and window management code (which should mostly be in the controller side of things) instead of combining both controller+model data into one object.

review: Needs Fixing

« Back to merge proposal