Mir

Code review comment for lp:~vanvugt/mir/frontend-server

Revision history for this message
Kevin DuBois (kdub) wrote :

mf::Shell (in lp:mir/devel) has open_session, close_session, create_surface_for, and handle_surface_created.

I've had the thought before that create_surface_for() doesn't quite fit with the rest of the interface, and that the session should should have a create_surface() method instead of mf::Shell having a create_surface_for() method.

So, create_surface_for() and handle_surface_created() seemed like misplaced functions on this interface, and the primary purpose of this interface is to create sessions.... so maybe mf::Shell should be mf::SessionFactory, and we should put a TODO/FIXME about the misplaced functions.

« Back to merge proposal