Mir

Code review comment for lp:~vanvugt/mir/fix-1655804

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> Resizing a window is perfectly valid, expected and supported. Resizing a
> window immediately on creation before the user has even seen it (and before
> the app has set a callback) is a bit unusual.

The app ought to set the callback on creation (that's why it is a property of the spec). And, if this fix is working, then it is clearly being called.

> No other windowing system (not
> tiling) I've ever seen does that. But indeed it's allowed if there are no
> resize constraints set.

It is allowed even if resize constraints have been set. (And required for some cases by the Mir & Unity8 design doc.)

> So it's allowed but unexpected. Continue discussion in LP: #1542029...

This is simply fixing a client bug, not working around a server issue.

review: Needs Fixing

« Back to merge proposal