Mir

Code review comment for lp:~vanvugt/mir/fix-1527449

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

The key difference and the reason why make_module_ptr doesn't work is something I documented here:

40 + // Must never be inlined!

whereas a template instance like UniqueModulePtr is instantiated in the plugin module itself. So unloading such a plugin module that implements the UniqueModulePtr will crash and can never be safe.

« Back to merge proposal