Mir

Code review comment for lp:~vanvugt/mir/fix-1527449

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Good question. Yes, a few reasons for that:

1. I wrote Plugin long before noticing make_module_ptr existed.
2. Plugin is simpler, more elegant, smaller, fewer templates, easier to understand, and provides a handy debugging feature which tells you you've made a mistake before you encounter cryptic unmapped memory crashes.
3. AFAIK Plugin is also more reliable, as make_module_ptr is still known to cause serious problems -> bug 1528135

« Back to merge proposal