Mir

Code review comment for lp:~vanvugt/mir/fix-1527449-Plugin

Revision history for this message
Kevin DuBois (kdub) wrote :

LGTM, nonblocking:

+ // Must never be inlined!
+ Plugin();

could __attribute__ (noinline) be used?

+ auto modules = mir::libraries_for_path(path,
+ *shared_library_prober_report);
could be one line.

review: Approve

« Back to merge proposal