Mir

Code review comment for lp:~vanvugt/mir/fix-1510778

Revision history for this message
Andreas Pokorny (andreas-pokorny) wrote :

not sure why you care so much about blaming particular changes.. but the hard coding to armhf was added in r2907 already.

Needs Fixing:
if (MIR_TEST_PLATFORM STREQUAL "mesa-x11")
should be
if (MIR_BUILD_PALTFORM_MESA_X11)
instead.
Within unit-tests the MIR_TEST_PLATFORM kludge is only needed within certain tests that rely on differences in stubs wrt to NativeBuffer as far as I can tell.

review: Needs Fixing

« Back to merge proposal