1
=== modified file 'src/common/sharedlibrary/shared_library_prober.cpp'
2
--- src/common/sharedlibrary/shared_library_prober.cpp	2015-06-17 05:20:42 +0000
3
+++ src/common/sharedlibrary/shared_library_prober.cpp	2015-07-10 08:22:42 +0000
4
@@ -57,7 +57,7 @@
5
57
    boost::filesystem::directory_iterator iterator{path, ec};
57
    boost::filesystem::directory_iterator iterator{path, ec};
6
58
    if (ec)
58
    if (ec)
7
59
    {
59
    {
9
60
        std::system_error error{boost_to_std_error(ec)};
60
        std::system_error error(boost_to_std_error(ec), path);
10
61
        report.probing_failed(path, error);
61
        report.probing_failed(path, error);
11
62
        throw error;
62
        throw error;
12
63
    }
63
    }
13
64
64
14
=== modified file 'tests/unit-tests/test_shared_library_prober.cpp'
15
--- tests/unit-tests/test_shared_library_prober.cpp	2015-06-18 02:46:16 +0000
16
+++ tests/unit-tests/test_shared_library_prober.cpp	2015-07-10 08:22:42 +0000
17
@@ -84,6 +84,23 @@
18
84
                 std::system_error);
84
                 std::system_error);
19
85
}
85
}
20
86
86
21
87
TEST_F(SharedLibraryProber, exception_mentions_missing_path_name)
22
88
{
23
89
    bool thrown = false;
24
90
25
91
    try
26
92
    {
27
93
        mir::libraries_for_path("/panacea", null_report);
28
94
    }
29
95
    catch (std::system_error& err)
30
96
    {
31
97
        thrown = true;
32
98
        EXPECT_THAT(err.what(), testing::HasSubstr("/panacea"));
33
99
    }
34
100
35
101
    EXPECT_TRUE(thrown);
36
102
}
37
103
38
87
TEST_F(SharedLibraryProber, non_existent_path_raises_ENOENT_error)
104
TEST_F(SharedLibraryProber, non_existent_path_raises_ENOENT_error)
39
88
{
105
{
40
89
    try
106
    try
Reviewer	Review Type	Date Requested	Status
Robert Ancell			Approve on 2015-07-12
Cemil Azizoglu (community)		2015-07-10	Approve on 2015-07-10
PS Jenkins bot (community)	continuous-integration		Approve on 2015-07-10
Review via email: mp+264387@code.launchpad.net
1	=== modified file 'src/common/sharedlibrary/shared_library_prober.cpp'
2	--- src/common/sharedlibrary/shared_library_prober.cpp 2015-06-17 05:20:42 +0000
3	+++ src/common/sharedlibrary/shared_library_prober.cpp 2015-07-10 08:22:42 +0000
4	@@ -57,7 +57,7 @@
5	57	boost::filesystem::directory_iterator iterator{path, ec};	57	boost::filesystem::directory_iterator iterator{path, ec};
6	58	if (ec)	58	if (ec)
7	59	{	59	{
9	60	std::system_error error{boost_to_std_error(ec)};	60	std::system_error error(boost_to_std_error(ec), path);
10	61	report.probing_failed(path, error);	61	report.probing_failed(path, error);
11	62	throw error;	62	throw error;
12	63	}	63	}
13	64		64
14	=== modified file 'tests/unit-tests/test_shared_library_prober.cpp'
15	--- tests/unit-tests/test_shared_library_prober.cpp 2015-06-18 02:46:16 +0000
16	+++ tests/unit-tests/test_shared_library_prober.cpp 2015-07-10 08:22:42 +0000
17	@@ -84,6 +84,23 @@
18	84	std::system_error);	84	std::system_error);
19	85	}	85	}
20	86		86
21			87	TEST_F(SharedLibraryProber, exception_mentions_missing_path_name)
22			88	{
23			89	bool thrown = false;
24			90
25			91	try
26			92	{
27			93	mir::libraries_for_path("/panacea", null_report);
28			94	}
29			95	catch (std::system_error& err)
30			96	{
31			97	thrown = true;
32			98	EXPECT_THAT(err.what(), testing::HasSubstr("/panacea"));
33			99	}
34			100
35			101	EXPECT_TRUE(thrown);
36			102	}
37			103
38	87	TEST_F(SharedLibraryProber, non_existent_path_raises_ENOENT_error)	104	TEST_F(SharedLibraryProber, non_existent_path_raises_ENOENT_error)
39	88	{	105	{
40	89	try	106	try