Merge lp:~vanvugt/mir/fix-1473268 into lp:mir

[Daniel van Vugt]

Improved shared library loading error messages to include the path
that can't be found. Instead of simply "No such file or directory",
you will now see "/the/path/tried/: No such file or directory".
(LP: #1473268)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:2736
http://jenkins.qa.ubuntu.com/job/mir-ci/4300/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/3134
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-wily-amd64-build/657
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/3082
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/449
        deb: http://jenkins.qa.ubuntu.com/job/mir-wily-amd64-ci/449/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/3082
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/3082/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/5887
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/21780

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/4300/rebuild

review: Approve (continuous-integration)

[Cemil Azizoglu (cemil-azizoglu)]

Ok

review: Approve

[Robert Ancell (robert-ancell)]

Looks like a much better error.

review: Approve

=== modified file 'src/common/sharedlibrary/shared_library_prober.cpp'
--- src/common/sharedlibrary/shared_library_prober.cpp	2015-06-17 05:20:42 +0000
+++ src/common/sharedlibrary/shared_library_prober.cpp	2015-07-10 08:22:42 +0000
@@ -57,7 +57,7 @@
     boost::filesystem::directory_iterator iterator{path, ec};
     if (ec)
     {
-        std::system_error error{boost_to_std_error(ec)};
+        std::system_error error(boost_to_std_error(ec), path);
         report.probing_failed(path, error);
         throw error;
     }

=== modified file 'tests/unit-tests/test_shared_library_prober.cpp'
--- tests/unit-tests/test_shared_library_prober.cpp	2015-06-18 02:46:16 +0000
+++ tests/unit-tests/test_shared_library_prober.cpp	2015-07-10 08:22:42 +0000
@@ -84,6 +84,23 @@
                  std::system_error);
 }
 
+TEST_F(SharedLibraryProber, exception_mentions_missing_path_name)
+{
+    bool thrown = false;
+
+    try
+    {
+        mir::libraries_for_path("/panacea", null_report);
+    }
+    catch (std::system_error& err)
+    {
+        thrown = true;
+        EXPECT_THAT(err.what(), testing::HasSubstr("/panacea"));
+    }
+
+    EXPECT_TRUE(thrown);
+}
+
 TEST_F(SharedLibraryProber, non_existent_path_raises_ENOENT_error)
 {
     try