Mir

Code review comment for lp:~vanvugt/mir/fix-1358625

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

[libprotobuf ERROR google/protobuf/descriptor_database.cc:57] File already exists in database: mir_protobuf_wire.proto
[libprotobuf FATAL google/protobuf/descriptor.cc:954] CHECK failed: generated_database_->Add(encoded_file_descriptor, size):
terminate called after throwing an instance of 'google::protobuf::FatalException'
what(): CHECK failed: generated_database_->Add(encoded_file_descriptor, size):
Aborted (core dumped)

lp:1358698

~~~~

I'm not convinced that this is the best approach - looking at the example code I think the right answer could be:

#undef NDEBUG
#include <assert.h>

there is no error handling.

review: Abstain

« Back to merge proposal