Mir

Code review comment for lp:~vanvugt/mir/fix-1319765

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

kdub:

Yeah it's a complicated (and redundant) test that is mostly just a repeatable copy of the simple test before it. I wanted to iterate it many times to verify the fix didn't just work on the first iteration, and stress it a bit.

Not sure what you mean by "smarter callback system". This proposal ensures all callbacks are made as soon as logically possible (catching the one(?) case where that wasn't already guaranteed). Although I suspect you might be referring to an automatic callback system where callbacks happen implicitly from queue changes...? That would be interesting if it simplified the algorithm (not interesting otherwise :). But that's also not a task for right now.

« Back to merge proposal