Mir

Merge lp:~vanvugt/mir/fix-1191636 into lp:~mir-team/mir/trunk

Proposed by Daniel van Vugt
Status: Merged
Approved by: Alexandros Frantzis
Approved revision: no longer in the source branch.
Merged at revision: 746
Proposed branch: lp:~vanvugt/mir/fix-1191636
Merge into: lp:~mir-team/mir/trunk
Diff against target: 20 lines (+5/-5)
1 file modified
tools/setup-android-dependencies.sh (+5/-5)
To merge this branch: bzr merge lp:~vanvugt/mir/fix-1191636
Reviewer Review Type Date Requested Status
Alexandros Frantzis (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+169715@code.launchpad.net

Commit message

setup-android-dependencies.sh: Don't prompt for confirmation when running a
script in adb shell. It doesn't receive keystrokes so will hang forever.
(LP: #1191636)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tools/setup-android-dependencies.sh'
--- tools/setup-android-dependencies.sh 2013-06-14 07:12:05 +0000
+++ tools/setup-android-dependencies.sh 2013-06-17 03:19:27 +0000
@@ -21,11 +21,11 @@
21 echo "ubuntu_chroot shell;21 echo "ubuntu_chroot shell;
22 cd /root;22 cd /root;
23 dpkg -i libgflags2_2.0-1_armhf.deb libgoogle-glog0_0.3.2-4ubuntu1_armhf.deb23 dpkg -i libgflags2_2.0-1_armhf.deb libgoogle-glog0_0.3.2-4ubuntu1_armhf.deb
24 apt-get install libprotobuf7 \24 apt-get -y install libprotobuf7 \
25 libboost-system1.49.0 \25 libboost-system1.49.0 \
26 libboost-program-options1.49.0 \26 libboost-program-options1.49.0 \
27 libboost-thread1.49.0 \27 libboost-thread1.49.0 \
28 libxkbcommon028 libxkbcommon0
2929
30 exit;30 exit;
31 exit" | adb shell31 exit" | adb shell

Subscribers

People subscribed via source and target branches