Mir

Merge lp:~vanvugt/mir/fix-1168304 into lp:mir

Proposed by Daniel van Vugt
Status: Merged
Approved by: Daniel van Vugt
Approved revision: no longer in the source branch.
Merged at revision: 1231
Proposed branch: lp:~vanvugt/mir/fix-1168304
Merge into: lp:mir
Diff against target: 55 lines (+8/-9)
2 files modified
examples/eglapp.c (+6/-8)
include/shared/mir_toolkit/client_types.h (+2/-1)
To merge this branch: bzr merge lp:~vanvugt/mir/fix-1168304
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Kevin DuBois (community) Approve
Alan Griffiths Approve
Review via email: mp+195568@code.launchpad.net

Commit message

eglapp: Clarify messages about pixel formats (LP: #1168304)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Build failure appears to be unrelated

review: Approve
Revision history for this message
Kevin DuBois (kdub) wrote :

lgtm

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'examples/eglapp.c'
--- examples/eglapp.c 2013-10-07 09:21:27 +0000
+++ examples/eglapp.c 2013-11-18 10:07:45 +0000
@@ -300,12 +300,11 @@
300300
301 const MirDisplayMode *mode = &output->modes[output->current_mode];301 const MirDisplayMode *mode = &output->modes[output->current_mode];
302302
303 const unsigned int max_formats = 10;303 unsigned int format[mir_pixel_formats];
304 unsigned int format[max_formats];
305 unsigned int nformats;304 unsigned int nformats;
306305
307 mir_connection_get_available_surface_formats(connection,306 mir_connection_get_available_surface_formats(connection,
308 format, max_formats, &nformats);307 format, mir_pixel_formats, &nformats);
309308
310 surfaceparm.pixel_format = format[0];309 surfaceparm.pixel_format = format[0];
311 for (unsigned int f = 0; f < nformats; f++)310 for (unsigned int f = 0; f < nformats; f++)
@@ -322,18 +321,17 @@
322 }321 }
323 }322 }
324323
325 printf("Connected to display: resolution (%dx%d), position(%dx%d), "324 printf("Current active output is %dx%d %+d%+d\n",
326 "supports %d pixel formats\n",
327 mode->horizontal_resolution, mode->vertical_resolution,325 mode->horizontal_resolution, mode->vertical_resolution,
328 output->position_x, output->position_y,326 output->position_x, output->position_y);
329 output->num_output_formats);
330327
331 surfaceparm.width = *width > 0 ? *width : mode->horizontal_resolution;328 surfaceparm.width = *width > 0 ? *width : mode->horizontal_resolution;
332 surfaceparm.height = *height > 0 ? *height : mode->vertical_resolution;329 surfaceparm.height = *height > 0 ? *height : mode->vertical_resolution;
333330
334 mir_display_config_destroy(display_config);331 mir_display_config_destroy(display_config);
335332
336 printf("Using pixel format #%d\n", surfaceparm.pixel_format);333 printf("Server supports %d of %d surface pixel formats. Using format: %d\n",
334 nformats, mir_pixel_formats, surfaceparm.pixel_format);
337 unsigned int bpp = get_bpp(surfaceparm.pixel_format);335 unsigned int bpp = get_bpp(surfaceparm.pixel_format);
338 EGLint attribs[] =336 EGLint attribs[] =
339 {337 {
340338
=== modified file 'include/shared/mir_toolkit/client_types.h'
--- include/shared/mir_toolkit/client_types.h 2013-09-12 21:36:55 +0000
+++ include/shared/mir_toolkit/client_types.h 2013-11-18 10:07:45 +0000
@@ -112,7 +112,8 @@
112 mir_pixel_format_xbgr_8888,112 mir_pixel_format_xbgr_8888,
113 mir_pixel_format_argb_8888,113 mir_pixel_format_argb_8888,
114 mir_pixel_format_xrgb_8888,114 mir_pixel_format_xrgb_8888,
115 mir_pixel_format_bgr_888115 mir_pixel_format_bgr_888,
116 mir_pixel_formats
116} MirPixelFormat;117} MirPixelFormat;
117118
118/**119/**

Subscribers

People subscribed via source and target branches