Code review comment for lp:~vanvugt/mir/earlier-release-2
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
All good points and they were on my mind already.
It really is a prediction algorithm, whether there's a single or multiple compositors. If we get the prediction wrong for a frame or so (second monitor hotplugged?) the client will get a buffer back a little too quickly, but that's really just one frame so not important.
Yes "overclocking" is an overloaded word here. I was looking for a single term to describe the problem and that's the best short description I've found. But it's definitely confusing and not related to physical monitor signal overclocking, which is a thing.
The new integration tests - I've used your new interfaces previously where it was clear how to do so. Sorry in some of this work it's not clear to me how to do so. I imagine some translation will happen later...