Code review comment for lp:~vanvugt/mir/disable-early-release
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
Yes I remember asking you to go round in circles coming up with the name MultiMonitorMode (sorry). It's still not ideal, but I intentionally want to separate renaming discussions from this just being a minor fix.
As for deleting the setting completely, I did consider that but recommend against it right now because:
* The diff would be much larger, and require changes to NBS; and
* It's a stable well-tested feature we might want to re-enable at some point in future.
Normally the argument is to remove unused code because it can always be restored easily. But that's not true for buffering-related features because we tend to break things enough that not having it permanently under test makes it very difficult to work back in in future (think of double buffering support which is in the same boat and I've progressively had to reinforce the test suite as we kept breaking it while it was unused). So I'd rather keep the feature and its tests for now.