Code review comment for lp:~vanvugt/mir/compositor-test

I have considered those things already, so should explain...

Bourne shell: is much more appropriate for simple command-line driven tests. And there will be more in future that are simple external commands, not C/C+ code. More like system tests.

gtest:
https://code.launchpad.net/~vanvugt/mir/generalise-performance-tests/+merge/292600/comments/750962

Parameters: that's actually not important and even not sensible. Because a regression test should be difficult to break. Making the threshold for your regression test a parameter makes it too easy to pass the test by accident.

krillin: Actually when bug 1563287 is present, krillin drops to 20Hz (and the test fails), so a threshold of 55 is fine.