Mir

Code review comment for lp:~vanvugt/mir/compositor-test-in-c-minor

Revision history for this message
Kevin DuBois (kdub) wrote :

Would prefer this to the bash.

+ EXPECT_GE(compositor_fps, 58.0f);
iirc, we've had 55fps devices before. (and krillin is 66fps). Would be better to check the display configuration

+ bin_dir+"/mir_demo_server --compositor-report=log -f "+mir_sock;
Would prefer to override the compositor report, so then we would rely on our API instead of log parsing. We could also probably use our existing test infrastructure for starting servers? (although, we probably need some hygiene by now to get the acceptance tests to run against the real drivers easily.)

So I guess (given the difficulties of using our test infrastructure + server API to check this), alright by me, after making the compositor fps check a bit more robust.

review: Approve

« Back to merge proposal