Mir

Code review comment for lp:~vanvugt/mir/compositor-report

Revision history for this message
Andreas Pokorny (andreas-pokorny) wrote :

> I disagree with breaking up finished_frame. In its current form it is highly
> cohesive.

It does two things. it updates one "Instance" and if timeout is big enough it creates reports for each instance and logs them. So the second thing is two things again, calculating and resetting the Riemann sums and formatting and printing the log string.

Why are the "last_reported_*" time values updated even when no report took place?

« Back to merge proposal