Mir

Code review comment for lp:~vanvugt/mir/bypass

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

50 -private:
51 +protected:

BasicDisplayBufferCompositor is a weird piece of design an this makes it weirder. (Protected member data increases coupling and suggests poor coherence.)

Existing issue here: What on earth does "void BasicDisplayBufferCompositor::composite()" convey to the user?

But this MP is probably not the place to address this (unless a better design makes other things simpler).

« Back to merge proposal