Code review comment for lp:~vanvugt/mir/bypass
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
Alexandros,
1. Pure virtual: Disagree
"Consistency" in this case would just produce unreachable and confusing code. It would increase code bloat, reduce test coverage and likely confuse anyone reading it.
2. last_flipped_
3. Ugly casting: Fixed as you suggested
4. Tconst&: Disagree
I've been using "const T&" ever since I raised the issue;
https:/
https:/
I hoped that others would follow, but the conversation went quiet.