Mir

Code review comment for lp:~vanvugt/mir/bypass

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

A quick first pass:

37 + virtual void post_update(std::shared_ptr<Buffer> /* bypass_buf */) {}

DisplayBuffer should be a pure abstract (interface) class.

701 + last_flipped_bypass_buf = bypass_buf; // Can be nullptr

The variable isn't used anywhere else.

673 + auto native = bypass_buf->native_buffer_handle();
674 + struct gbm_bo *bo = *(struct gbm_bo**)native->data;
675 + bufobj = get_buffer_object(bo);

Since we are making the assumption that the mg::Buffer is a GBMBuffer, why not cast to a GBMBuffer and provide a GBMBuffer::get_buffer_object() method?

review: Needs Fixing

« Back to merge proposal