Code review comment for lp:~vanvugt/mir/async-is-not-sync
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
That makes perfect, but partial sense.
The sole justification for looking at doing a 1.0 release soon was to get the API right. And this certainly comes under that heading. Although realistically I don't think we're going to get everything right in 1.0.
Your justification for rejecting this branch is actually a strong argument against the wide scale API breaks we've been pushing through at high speed recently. Indeed we've broken too much too quickly. If we acknowledge and accept that then I think this branch should be a part of it, and helps us to get the API closer to right.