Code review comment for lp:~vanvugt/mir/async-is-not-sync

This was discussed in the standup. I'll summarize the opinions against it to go with Alberto's favorable opinion above.

What you are proposing is to change not just what this MP changes but all the async/sync functions. This is a huge change (evidenced by the size of this branch just to change one of them). We do not have the time to do it in Mir 0.26 timeframe for sure - it's already late. Besides, toolkits have already written their code, and renaming to make their lives easier will make it harder for them because now they'd have to change their code to adapt to all the new names.

Another argument against this is that calling out 'sync' in the function name provides a visual clue for the user that this function may take longer than other functions that do not have 'sync' suffix (i.e. do not need to contact to server).

Yet another argument is that it's a lot of busy work for not enough gain (even if we didn't take the time crunch that we're in into account).

We can have a wider team discussion in an upcoming sprint to see if everyone can be convinced that this is a good idea.