Mir

Code review comment for lp:~vanvugt/mir/async-is-not-sync

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Apart from "too late now" there are two arguments:

/1/ the "sync" version is more common and should have the shorter name
/2/ the "sync" version is more specialized and should have the longer name

The former is certainly true of our test and example code. (I'm not sure of a good codebase to assess it in the real world.)

The latter is also true. It also calls out that call might take some significant time to return.

I'm marginally in favour of what we have now.

review: Disapprove

« Back to merge proposal