Mir

Code review comment for lp:~vanvugt/mir/Rectangle-contains-Rectangle

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Alexandros:
Fixed and fixed. I think there was some copy/paste or search/replace mistake there.

Kevin:
The cppguide says it "favors" the late const form without providing any solid justification other than loosely mentioning "This keeps the const with the type modifier (& or *)". So firstly, that's not a justification. The C/C++ language specs clearly define "const" as applying to the type and not the type modifier. So late const is misleading in the least. It creates confusion if you try to express "const T * const p", which is more clearly stated with prefix const. And the suffix const form is syntactically impossible for expressing "T * const p". So I think we need to update the cppguide... I mentioned this on the mailing list some time back.

« Back to merge proposal